Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac merged PR #15221: URL: https://github.com/apache/kafka/pull/15221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac commented on PR #15221: URL: https://github.com/apache/kafka/pull/15221#issuecomment-1912050490 Thanks, @jolshan! The last build looks good. I will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

jolshan commented on PR #15221: URL: https://github.com/apache/kafka/pull/15221#issuecomment-1911033187 Hmmm -- something seems to be up with builds. https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/activity?branch=PR-15221 I will retrigger? -- This is an au

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac commented on PR #15221: URL: https://github.com/apache/kafka/pull/15221#issuecomment-1909715095 @jolshan @jeffkbkim @rreddy-22 @dongnuo123 Thanks for your comments. I have addressed all of them. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1466057301 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -501,13 +521,11 @@ public void testOffsetDeleteWith(

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

rreddy-22 commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1464202116 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -604,22 +602,23 @@ public CoordinatorResult deleteOffsets(

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

jolshan commented on PR #15221: URL: https://github.com/apache/kafka/pull/15221#issuecomment-1907178903 Took a first pass. I will look again tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

jolshan commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1464178480 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -501,13 +521,11 @@ public void testOffsetDeleteWith(

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

jolshan commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1464175850 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -2342,26 +2375,24 @@ public void testConsumerGroupOffsetDele

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1462856785 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -604,22 +602,23 @@ public CoordinatorResult deleteOffsets(

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1462855794 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -501,13 +521,11 @@ public void testOffsetDeleteWith(

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

jeffkbkim commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1462314538 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -501,13 +521,11 @@ public void testOffsetDeleteWith(

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac commented on PR #15221: URL: https://github.com/apache/kafka/pull/15221#issuecomment-1899953142 @jeffkbkim @dongnuo123 Thanks for your comments. I addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1458553635 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -856,7 +899,8 @@ public boolean cleanupExpiredOffsets(String group

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dongnuo123 commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1458085202 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -856,7 +899,8 @@ public boolean cleanupExpiredOffsets(String

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

jeffkbkim commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1457909168 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -685,6 +712,20 @@ private boolean hasPendingTransactionalOffse

[PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

dajac opened a new pull request, #15221: URL: https://github.com/apache/kafka/pull/15221 This is the last patch to complete the implementation of the transactional offsets. This patch updates the following paths: * delete offsets - the patch ensures that a tombstone is written for pending