Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-12-01 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1411799674 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -547,6 +549,69 @@ public CompletableFuture listGroups(

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-30 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1411265076 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,32 @@ public String currentAssignmentSummar

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408986511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -943,4 +944,19 @@ private static Integer decValue(String key, Int

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408928899 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,32 @@ public String currentAssignmentSummary()

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408924119 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -445,6 +446,42 @@ public List listGroups(List statesFi re

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-28 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408365148 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -468,6 +468,52 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-28 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1408103278 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6206,12 +6206,40 @@ class KafkaApisTest { assertEquals(Errors.GROUP_AUTHORIZATION_FAILED.cod

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-26 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1405422751 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -445,6 +446,42 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-26 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1405412781 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,32 @@ public String currentAssignmentSummar