Re: [PR] KAFKA-14509: [2/N] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-12-04 Thread via GitHub
dajac merged PR #14544: URL: https://github.com/apache/kafka/pull/14544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-14509: [2/N] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-12-01 Thread via GitHub
riedelmax commented on PR #14544: URL: https://github.com/apache/kafka/pull/14544#issuecomment-1836279426 Hey @dajac thanks for the review. I addressed all the points except for the ones we intent to do a follow up. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-14509: [2/N] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-12-01 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1411829247 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -547,6 +549,69 @@ public CompletableFuture listGroups(