dajac commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2158198985
Merged to trunk and to 3.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dajac merged PR #16158:
URL: https://github.com/apache/kafka/pull/16158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2157499078
CI does not seem to be working...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dajac commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2157411292
Merged trunk to include https://github.com/apache/kafka/pull/16249.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156662574
I prefer to check all failed tests before merging. And the last commit of
this PR does not have completed CI. That is why I suggest to rebase code to
trigger QA again.
--
This is an a
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156661854
@riedelmax #16249 fix the blocked tests. Without that fix, the CI will get
timeout when running your PR
--
This is an automated message from the Apache Git Service.
To respond to the m
riedelmax commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156601592
@chia7712 would you mind to explain how #16249 effects this PR? if there are
no conflicts with trunk i dont need to rebase or merge manually right?
--
This is an automated message fro
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156006198
@riedelmax please rebase code to have the fix #16249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
riedelmax commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1631440593
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -116,6 +115,7 @@ class ConsumerGroupDescribeRequestsTest(cluster:
ClusterInst
dajac commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1631388315
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -116,6 +115,7 @@ class ConsumerGroupDescribeRequestsTest(cluster:
ClusterInstance
dajac commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1631285093
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -7086,6 +7086,7 @@ class KafkaApisTest extends Logging {
def testConsumerGroupDescribe(): Unit = {
riedelmax commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1631203974
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -7086,6 +7086,7 @@ class KafkaApisTest extends Logging {
def testConsumerGroupDescribe(): Unit
dajac commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1631057079
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -7107,11 +7108,12 @@ class KafkaApisTest extends Logging {
).asJava)
// Can't reuse the ab
dajac commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2154635171
@riedelmax There are a bunch of conflicts. Could you please fix them?
Regarding `ConsumerGroupDescribeRequestsTest`, is it possible to extend it too?
--
This is an automated message from
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146691340
> We have some integration tests in ConsumerGroupDescribeRequestTest
thanks for this reminder. I neglect that before :(
--
This is an automated message from the Apache Git Servic
riedelmax commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146678085
@chia7712 im not sure if I understand you correctlu. We have some
integration tests in `ConsumerGroupDescribeRequestTest`
--
This is an automated message from the Apache Git Service.
riedelmax commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1625394359
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -7086,6 +7086,7 @@ class KafkaApisTest extends Logging {
def testConsumerGroupDescribe(): Unit
riedelmax commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146676215
@dajac thanks for checking so quickly. I will have time on friday to do the
integration tet
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
dajac commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1623901700
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -7086,6 +7086,7 @@ class KafkaApisTest extends Logging {
def testConsumerGroupDescribe(): Unit = {
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2143262308
out of curiosity, do we have IT for that option? I grep code base and it
seems the related ITs are running with old coordinator/protocol. For example:
1.
https://github.com/apach
dajac commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1622909655
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3852,6 +3853,17 @@ class KafkaApis(val requestChannel: RequestChannel,
if (exception != null) {
dajac commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2142879003
@riedelmax Thanks for the patch. Could you please extend unit and
integration tests to cover this change?
--
This is an automated message from the Apache Git Service.
To respond to the me
riedelmax opened a new pull request, #16158:
URL: https://github.com/apache/kafka/pull/16158
Last PR for KAFKA-14509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
23 matches
Mail list logo
