Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-21 Thread via GitHub
dajac commented on PR #14544: URL: https://github.com/apache/kafka/pull/14544#issuecomment-1821237941 I have also noted that the code does not compile. Could you check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-21 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1400669970 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3693,8 +3693,49 @@ class KafkaApis(val requestChannel: RequestChannel, } def handleConsumerGroupDescri

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-19 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1398686956 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6465,12 +6465,42 @@ class KafkaApisTest { assertEquals(Errors.GROUP_AUTHORIZATION_FAILED.cod

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-18 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1398242511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -445,6 +446,42 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-18 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1398242511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -445,6 +446,42 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-18 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1398242438 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,32 @@ public String currentAssignmentSummar

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-18 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1398236262 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -8660,6 +8665,68 @@ public void testListGroups() {

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-16 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1396140016 ## clients/src/main/java/org/apache/kafka/common/requests/ConsumerGroupDescribeRequest.java: ## @@ -83,4 +85,16 @@ public static ConsumerGroupDescribeRequest parse(ByteBu

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-14 Thread via GitHub
dongnuo123 commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1392707829 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6206,12 +6206,40 @@ class KafkaApisTest { assertEquals(Errors.GROUP_AUTHORIZATION_FAILED.co

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382621146 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,26 @@ public String currentAssignmentSummar

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382617127 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,26 @@ public String currentAssignmentSummar

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382608784 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -444,6 +445,43 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-05 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1382605249 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6206,12 +6206,40 @@ class KafkaApisTest { assertEquals(Errors.GROUP_AUTHORIZATION_FAILED.cod

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-31 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1377837063 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -444,6 +445,43 @@ public List listGroups(List statesFi re

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-31 Thread via GitHub
dajac commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1377836361 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,26 @@ public String currentAssignmentSummary()

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-29 Thread via GitHub
dongnuo123 commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1375454303 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3686,8 +3686,51 @@ class KafkaApis(val requestChannel: RequestChannel, } def handleConsumerGroupD

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-20 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1367479438 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6206,12 +6206,40 @@ class KafkaApisTest { assertEquals(Errors.GROUP_AUTHORIZATION_FAILED.cod

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-20 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1367392319 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -444,6 +445,43 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-16 Thread via GitHub
dongnuo123 commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1361149813 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -151,6 +152,19 @@ CompletableFuture> describeGroup List

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-13 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1358491232 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -444,6 +445,43 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-13 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1358490015 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,26 @@ public String currentAssignmentSummar

Re: [PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-13 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1358489037 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,26 @@ public String currentAssignmentSummar

[PR] KAFKA-14509 [WIP] [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-10-13 Thread via GitHub
riedelmax opened a new pull request, #14544: URL: https://github.com/apache/kafka/pull/14544 This PR contains the implementation of server side logic for the new ConsumerGroupDescribe API. It is still WIP. See my open questions in the comment section. ### Committer Checklist (e