chia7712 merged PR #15873:
URL: https://github.com/apache/kafka/pull/15873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nizhikov commented on PR #15873:
URL: https://github.com/apache/kafka/pull/15873#issuecomment-2106822242
Hello @chia7712
I'm back online :)
Do you have any other comments for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
nizhikov commented on PR #15873:
URL: https://github.com/apache/kafka/pull/15873#issuecomment-2101427991
JFYI I’m offline till Monday.
Will fix all possible comments after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1594336755
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,432 @@ public void testOptionEntityTypeNames() {
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1593927539
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,432 @@ public void testOptionEntityTypeNames() {
chia7712 commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1593681340
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,432 @@ public void testOptionEntityTypeNames() {
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1592313103
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,430 @@ public void testOptionEntityTypeNames() {
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1592249836
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -418,4 +880,77 @@ public static String[] toArray(String... first) {
public static String[]
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1592249836
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -418,4 +880,77 @@ public static String[] toArray(String... first) {
public static String[]
nizhikov commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1592246946
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,430 @@ public void testOptionEntityTypeNames() {
chia7712 commented on code in PR #15873:
URL: https://github.com/apache/kafka/pull/15873#discussion_r1591722419
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -410,6 +448,430 @@ public void testOptionEntityTypeNames() {
nizhikov commented on PR #15873:
URL: https://github.com/apache/kafka/pull/15873#issuecomment-2096190310
Hello @chia7712
Second part of `ConfigCommandTest` refactoring ready for review.
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond
nizhikov opened a new pull request, #15873:
URL: https://github.com/apache/kafka/pull/15873
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
13 matches
Mail list logo
