nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2024632660
@OmniaGM Thanks for noticing.
https://github.com/apache/kafka/pull/15614/files prepared
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
OmniaGM commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2024606943
@nizhikov it would be nice if we have a followup cleanup on this to change
PROP suffix to CONFIG as this seems to be the pattern for others and am doing
the same for the rest of KafkaConf
chia7712 merged PR #15075:
URL: https://github.com/apache/kafka/pull/15075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022937094
```
./gradlew cleanTest :tools:test --tests
GetOffsetShellTest.testTopicPatternArgWithPartitionsArg :trogdor:test --tests
CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated :con
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022645115
@chia7712 CI are ready and seems OK for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chia7712 commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1540685634
##
server/src/main/java/org/apache/kafka/server/config/ZkConfig.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1540643481
##
server/src/main/java/org/apache/kafka/server/config/ZkConfig.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022177651
@chia7712 Conflicts resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022073236
@nizhikov Could you please rebase it again? Sorry for late review :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2020778443
@chia7712 All your comments resolved. Please, take a look one more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nizhikov commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1539513879
##
server/src/main/java/org/apache/kafka/server/config/ZkConfig.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1539504855
##
checkstyle/import-control-server.xml:
##
@@ -82,6 +82,9 @@
+
+
Review Comment:
Done.
##
checkstyle/import-control-jmh
nizhikov commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1539504425
##
server/src/main/java/org/apache/kafka/server/config/ZkConfig.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
chia7712 commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1539384087
##
server/src/main/java/org/apache/kafka/server/config/ZkConfig.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2017604728
@chia7712 Done.
Please, note, there are several other PR's with same goal #15569 #15575
which are close to mergeable state in my opinion.
--
This is an automated message from th
chia7712 commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2017574947
@nizhikov please rebase the code, and I will take a look later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-1963486539
Hello @mimaison @ijuma
Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-1948922545
Hello @mimaison @ijuma
This PR is ready for review.
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-1880988000
Hello @mimaison
This PR based on #14871 and includes changes mad in it.
I think it will be better to review #14871 and after it returns to these
changes.
Will add "[WIP]
mimaison commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1444500990
##
server-common/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java:
##
Review Comment:
These files don't seem to be related to ZooKeeper con
20 matches
Mail list logo
