nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1905956206
Thanks for review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jolshan merged PR #14856:
URL: https://github.com/apache/kafka/pull/14856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1904833683
Thanks. I will wait for the tests to finish 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mimaison commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1904738103
@jolshan Feel free to merge once you're happy with the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1462263439
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1904570844
Thanks @nizhikov just one more small comment from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jolshan commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1462243818
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1462054246
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/PartitionAssignmentState.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
mimaison commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1462033029
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/PartitionAssignmentState.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1903571070
Hello @mimaison , @jolshan do you have any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1457691847
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1492,6 +1501,20 @@ public static Set diff(final Supplier>
constructor, final Set l
mimaison commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1457296352
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1492,6 +1501,20 @@ public static Set diff(final Supplier>
constructor, final Set l
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1898096530
@mimaison CI seems OK. I addressed all your comments. Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456589544
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
Review Comment:
package renamed.
--
This
jolshan commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456587593
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
Review Comment:
That works for me. Thanks!
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456546534
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
Review Comment:
> I think when we have had t
jolshan commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456536862
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
Review Comment:
I wasn't sure if we wanted to
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456530381
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
Review Comment:
> Is the tools/consumergroup
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1896962207
@jolshan
> Did we want to delete the old files in this PR or a follow up?
For the previous command we remove old files only when command was merged
1. Reassign case
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456523688
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation (
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456521165
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation (
nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456518422
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/PartitionAssignmentState.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jolshan commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1896365557
Did we want to delete the old files in this PR or a follow up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jolshan commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456242441
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
Review Comment:
Is the tools/consumergroup a
mimaison commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456011084
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/PartitionAssignmentState.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1881507357
@mimaison can you, please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1845250099
Hello, @mimaison @jolshan
Looks like very straightforward PR for me.
Can you, please, review it, also?
So we can start moving `ConsumerGroupCommand` to tools.
Full
tledkov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1418448844
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation (A
tledkov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1418426538
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation (A
tledkov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1417541595
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -593,6 +593,16 @@ public static String join(T[] strs, String separator) {
return join
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1840840108
@mimaison Will you be able to take a look?
This is first PR to transfer `ConsumerGroupCommand` to java.
--
This is an automated message from the Apache Git Service.
To respond to
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1830131590
Hello @mimaison , @jolshan
This PR is first step to transfer `ConsumerGroupCommand` from scala to java.
Can you, please, take a look.
--
This is an automated message from the
nizhikov opened a new pull request, #14856:
URL: https://github.com/apache/kafka/pull/14856
This PR is part of #14471
It contains `ConsumerGroupCommandOptions` and case classes used by
`ConsumerGroupCommand` rewritten in java.
The goal of PR is to reduce main PR size.
### C
33 matches
Mail list logo
