jolshan merged PR #15248:
URL: https://github.com/apache/kafka/pull/15248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15248:
URL: https://github.com/apache/kafka/pull/15248#issuecomment-1912499332
Sorry I meant to check this one yesterday but accidentally looked at your
other PR. I thought I was waiting on build issues there, but should have been
looking here. Looking now.
--
nizhikov commented on PR #15248:
URL: https://github.com/apache/kafka/pull/15248#issuecomment-1910366005
Hello @jolshan
Do you have any other questions regarding this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465593791
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465593791
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465587429
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465586005
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465585471
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465574942
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465353561
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465353561
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465346754
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465339215
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465336810
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465333784
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #15248:
URL: https://github.com/apache/kafka/pull/15248#discussion_r1465332064
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupServiceTest.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on PR #15248:
URL: https://github.com/apache/kafka/pull/15248#issuecomment-1908611036
Hello @showuon
Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nizhikov commented on PR #15248:
URL: https://github.com/apache/kafka/pull/15248#issuecomment-1907703286
CI is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
nizhikov commented on PR #15248:
URL: https://github.com/apache/kafka/pull/15248#issuecomment-1906283629
@tledkov can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nizhikov commented on PR #15248:
URL: https://github.com/apache/kafka/pull/15248#issuecomment-1906283217
Hello @mimaison , @jolshan
I prepared second PR for KAFKA-14589.
It contains `ConsumerGroupServiceTest` rewritten in java.
Please, take a look.
--
This is an automated
20 matches
Mail list logo
