Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-05 Thread via GitHub
ableegoldman commented on PR #16147: URL: https://github.com/apache/kafka/pull/16147#issuecomment-2151097972 Cherrypicked to 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-04 Thread via GitHub
ableegoldman merged PR #16147: URL: https://github.com/apache/kafka/pull/16147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-04 Thread via GitHub
ableegoldman commented on PR #16147: URL: https://github.com/apache/kafka/pull/16147#issuecomment-2148162418 Test failures are unrelated. Merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-03 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1625023687 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -527,35 +531,44 @@ private ApplicationState buildApplica

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-03 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1624682684 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -245,55 +251,46 @@ private AssignmentState(final Appli

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-03 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1624657249 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -245,55 +251,46 @@ private AssignmentState(final Appli

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-03 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1624647021 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -331,7 +328,7 @@ public Set findClientsWithoutAssigned

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-06-03 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1624625757 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java: ## @@ -29,20 +32,47 @@ public class AssignmentConfigs { private fi

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623081838 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -245,55 +251,46 @@ private AssignmentState(final Ap

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623079947 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -173,6 +178,7 @@ private static void assignStandby(

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623078889 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -40,13 +41,17 @@ import org.apache.kafka.streams.p

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623064697 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -263,6 +267,8 @@ public Optional user

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623063757 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java: ## @@ -29,20 +32,47 @@ public class AssignmentConfigs { private

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623054265 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java: ## @@ -29,32 +33,59 @@ public class AssignmentConfigs { private fi

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623057182 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -40,13 +41,17 @@ import org.apache.kafka.streams.proc

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623054265 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java: ## @@ -29,32 +33,59 @@ public class AssignmentConfigs { private fi

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1623047318 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java: ## @@ -29,32 +33,59 @@ public class AssignmentConfigs { private

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1622591542 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java: ## @@ -481,10 +479,24 @@ private static int getCrossRackTrafficCost(f

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-31 Thread via GitHub
apourchet commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1622591542 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java: ## @@ -481,10 +479,24 @@ private static int getCrossRackTrafficCost(f

Re: [PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-30 Thread via GitHub
ableegoldman commented on code in PR #16147: URL: https://github.com/apache/kafka/pull/16147#discussion_r1621532246 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java: ## @@ -481,10 +479,24 @@ private static int getCrossRackTrafficCos

[PR] KAFKA-15045: (KIP-924 pt. 16) TaskAssignor.onAssignmentComputed handling [kafka]

2024-05-30 Thread via GitHub
apourchet opened a new pull request, #16147: URL: https://github.com/apache/kafka/pull/16147 This PR takes care of making the call back to`TaskAssignor.onAssignmentComputed`. It also contains a change to the public AssignmentConfigs API, as well as some simplifications of the StickyT