agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1500157846
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1500111316
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package
ijuma commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499955177
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499787175
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499784399
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package
ijuma commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499780993
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package
ableegoldman merged PR #14648:
URL: https://github.com/apache/kafka/pull/14648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on PR #14648:
URL: https://github.com/apache/kafka/pull/14648#issuecomment-1821731448
Looks like all the builds are compiling, but we have 18 flaky tests. I
checked all of them and none seem to be related to this PR. I also haven't seen
any concerns about any of the
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399973308
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##
@@ -91,11 +91,13 @@ private KeyValueStore
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399939069
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedInternal.java:
##
@@ -18,16 +18,30 @@
package
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399930568
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##
@@ -91,11 +91,13 @@ private KeyValueStore
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399822846
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##
@@ -91,11 +91,13 @@ private KeyValueStore
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399821160
##
streams/src/main/java/org/apache/kafka/streams/state/DslStoreSuppliers.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399820405
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedInternal.java:
##
@@ -18,16 +18,30 @@
package
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399812871
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software
ableegoldman commented on PR #14648:
URL: https://github.com/apache/kafka/pull/14648#issuecomment-1819878453
Haha yeah it's certainly grown quite a lot over the past few updates -- but
for that reason I'm actually fine with keeping it in one PR. The first time I
reviewed it there was
agavra commented on PR #14648:
URL: https://github.com/apache/kafka/pull/14648#issuecomment-1819373423
@guozhangwang I feel bad having such a large PR! It's grown slowly over
review cycles from ~500 lines to where it is now
@ableegoldman I'm happy to split the PR into two now
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398539065
##
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398539065
##
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
guozhangwang commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398306353
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r139828
##
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##
@@ -1038,13 +1038,15 @@ public void
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398270264
##
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398270071
##
streams/src/main/java/org/apache/kafka/streams/state/DslSessionParams.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398269890
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreFactory.java:
##
@@ -66,6 +66,10 @@ default void configure(final StreamsConfig config) {
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398269442
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398012157
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398006947
##
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##
@@ -1038,13 +1038,15 @@ public void
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398005349
##
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398004582
##
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398003882
##
streams/src/main/java/org/apache/kafka/streams/state/DslStoreSuppliers.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398003330
##
streams/src/main/java/org/apache/kafka/streams/state/DslSessionParams.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398002738
##
streams/src/main/java/org/apache/kafka/streams/state/DslSessionParams.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398002400
##
streams/src/main/java/org/apache/kafka/streams/state/BuiltInDslStoreSuppliers.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1397992729
##
streams/src/main/java/org/apache/kafka/streams/state/BuiltInDslStoreSuppliers.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1397987652
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1397982732
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreFactory.java:
##
@@ -66,6 +66,10 @@ default void configure(final StreamsConfig config)
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396641719
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396641322
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -16,17 +16,21 @@
*/
package org.apache.kafka.streams;
+import java.util.Optional;
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396641005
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConfig
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396638341
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396590225
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396586675
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396586675
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396551006
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396507648
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -16,17 +16,21 @@
*/
package org.apache.kafka.streams;
+import
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396517053
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConfig
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396517053
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConfig
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396493242
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396485217
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -529,14 +530,23 @@ public class StreamsConfig extends AbstractConfig {
private
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396484290
##
streams/src/main/java/org/apache/kafka/streams/state/BuiltinDslStoreSuppliers.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396482901
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -536,6 +537,11 @@ public class StreamsConfig extends AbstractConfig {
public
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396321548
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -536,6 +537,11 @@ public class StreamsConfig extends AbstractConfig {
public static
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1394939779
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConfig
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1393203579
##
streams/src/main/java/org/apache/kafka/streams/kstream/Materialized.java:
##
@@ -97,21 +128,21 @@ protected Materialized(final Materialized
materialized) {
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1393194762
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -536,6 +537,11 @@ public class StreamsConfig extends AbstractConfig {
public static
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1377093727
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -536,6 +537,11 @@ public class StreamsConfig extends AbstractConfig {
public
56 matches
Mail list logo
