satishd merged PR #16078:
URL: https://github.com/apache/kafka/pull/16078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #16078:
URL: https://github.com/apache/kafka/pull/16078#issuecomment-2163132425
There were a few unrelated test failures, merging it to trunk and 3.8
branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1635838998
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -817,6 +817,119 @@ class DynamicBrokerConfigTest {
Mockito.verifyNoMoreInteractio
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1635838230
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1165,43 +1165,66 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigu
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1635837473
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -817,6 +817,119 @@ class DynamicBrokerConfigTest {
Mockito.verifyNoMoreInteractio
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632316732
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -817,6 +817,119 @@ class DynamicBrokerConfigTest {
Mockito.verifyNoMoreInteractions(
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632316363
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -817,6 +817,119 @@ class DynamicBrokerConfigTest {
Mockito.verifyNoMoreInteractions(
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632220708
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1165,43 +1165,66 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurab
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632220708
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1165,43 +1165,66 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurab
abhijeetk88 commented on PR #16078:
URL: https://github.com/apache/kafka/pull/16078#issuecomment-2156228028
@satishd I have addressed your comments. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632133058
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1179,14 +1181,31 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigu
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632127666
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1195,13 +1214,19 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigu
abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632127500
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1166,7 +1166,9 @@ class DynamicRemoteLogConfig(server: KafkaBroker) extends
BrokerReconfigura
satishd commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1630655784
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1195,13 +1214,19 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurabl
satishd commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1630642185
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1166,7 +1166,9 @@ class DynamicRemoteLogConfig(server: KafkaBroker) extends
BrokerReconfigurable
abhijeetk88 commented on PR #16078:
URL: https://github.com/apache/kafka/pull/16078#issuecomment-2141989950
@showuon I have updated the PR after resolving conflicts. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on PR #16078:
URL: https://github.com/apache/kafka/pull/16078#issuecomment-2141698317
@abhijeetk88 , Please help resolve the merge conflict. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
17 matches
Mail list logo
