Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on PR #14626: URL: https://github.com/apache/kafka/pull/14626#issuecomment-1843861522 > @aliehsaeedii @mjsax The last build has many failed tests: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14626/26/tests. I also see them in

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

dajac commented on PR #14626: URL: https://github.com/apache/kafka/pull/14626#issuecomment-1843551173 @aliehsaeedii @mjsax The last build has many failed tests: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14626/26/tests. I also see them in other

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax merged PR #14626: URL: https://github.com/apache/kafka/pull/14626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1416297822 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java: ## @@ -88,7 +87,7 @@ public class IQv2VersionedStoreIntegrationTest

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1416208410 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java: ## @@ -153,14 +192,189 @@ private void

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1416206067 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java: ## @@ -153,14 +192,189 @@ private void

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1414568376 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1416196786 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java: ## @@ -471,15 +475,195 @@ public void

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1415599211 ## streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java: ## @@ -153,14 +192,189 @@ private void

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1414568376 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412552909 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412552909 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412530967 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key, final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412530967 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key, final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412530967 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key, final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412093650 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412048452 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1412048452 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1411969845 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key,

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1411961568 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key,

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1411947974 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -136,11 +139,11 @@ public long put(final Bytes key, final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1411475602 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -130,9 +129,9 @@ public Optional toTime() { /** * The order of

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on PR #14626: URL: https://github.com/apache/kafka/pull/14626#issuecomment-1828188305 @mjsax I think ready for next round of review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1404613145 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -170,7 +173,30 @@ public boolean isOpen() { @Override

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1404613145 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -170,7 +173,30 @@ public boolean isOpen() { @Override

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1404610275 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -263,6 +266,78 @@ public VersionedRecord get(final Bytes key,

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1396723148 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedRecordIterator.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1388177181 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -351,6 +383,21 @@ public static Function getDeserializeValue(final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387486212 ## streams/src/main/java/org/apache/kafka/streams/state/internals/VersionedRecordIterator.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387485646 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -351,6 +383,21 @@ public static Function getDeserializeValue(final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1379489069 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -253,6 +259,86 @@ public VersionedRecord get(final Bytes key, final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387482029 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -335,6 +345,28 @@ private static QueryResult runWindowRangeQuery(final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387481765 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -253,6 +259,86 @@ public VersionedRecord get(final Bytes key, final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387480142 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -157,6 +213,34 @@ protected QueryResult runKeyQuery(final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387479330 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387478307 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387478307 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1387475977 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1379474204 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on PR #14626: URL: https://github.com/apache/kafka/pull/14626#issuecomment-1802270514 @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384213430 ## streams/src/main/java/org/apache/kafka/streams/state/internals/VersionedRecordIterator.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384199383 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -351,6 +383,21 @@ public static Function getDeserializeValue(final

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384197764 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -253,6 +259,86 @@ public VersionedRecord get(final Bytes key,

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384186993 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -253,6 +259,86 @@ public VersionedRecord get(final Bytes key,

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384174245 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -157,6 +213,34 @@ protected QueryResult

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384174245 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -157,6 +213,34 @@ protected QueryResult

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384181132 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -335,6 +345,28 @@ private static QueryResult

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384178950 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -253,6 +259,86 @@ public VersionedRecord get(final Bytes key,

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384174245 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -157,6 +213,34 @@ protected QueryResult

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384162886 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384158149 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1384154474 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1383444278 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1379511059 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedRecord.java: ## @@ -27,6 +27,7 @@ public final class VersionedRecord { private final V value;

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1379469860 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

aliehsaeedii opened a new pull request, #14626: URL: https://github.com/apache/kafka/pull/14626 This is a POC PR for KIP-968. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific