viktorsomogyi commented on PR #15046:
URL: https://github.com/apache/kafka/pull/15046#issuecomment-1864102644
Closing this, it was merged in another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
viktorsomogyi closed pull request #15046: KAFKA-15366: Modify LogDirFailureTest
for KRaft
URL: https://github.com/apache/kafka/pull/15046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rondagostino merged PR #14977:
URL: https://github.com/apache/kafka/pull/14977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
rondagostino commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1863734568
Test failures are unrelated/flakes. JDK 8 tests were clean. All tests in
this PR passed. Merging to trunk and 3.7.
--
This is an automated message from the Apache Git Service.
T
viktorsomogyi commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1863205530
@rondagostino PTAL. There are test failures but I think those are flaky as
the scala 2.12 java 8 build got all green.
--
This is an automated message from the Apache Git Service.
viktorsomogyi commented on PR #15046:
URL: https://github.com/apache/kafka/pull/15046#issuecomment-1862858203
This is the cherry-pick of #14977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
viktorsomogyi opened a new pull request, #15046:
URL: https://github.com/apache/kafka/pull/15046
This commit modifies LogDirFailureTest to be compatible with KRaft based
JBOD functionality.
*More detailed description of your change,
if necessary. The PR title and PR message become
viktorsomogyi commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1862734998
@OmniaGM thanks, I've rebased it on trunk, hopefully they'll pass now, they
do locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
OmniaGM commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1862441390
Hey @viktorsomogyi let me know if #14998 didn't fix all the failing tests. I
and @gaurav-narula can have a look to fix any other bugs your test reveals
--
This is an automated message
rondagostino commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1861628384
> https://github.com/apache/kafka/pull/14998 blocks this PR, once we merge
it, I'll do a rebase and then the failing tests should pass.
@viktorsomogyi that PR is now merged. H
viktorsomogyi commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1859951986
@rondagostino yes, for now unfortunately #14998 blocks this PR, once we
merge it, I'll do a rebase and then the failing tests should pass.
--
This is an automated message from the
rondagostino commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1858462616
@viktorsomogyi I'm seeing these `kafka.server.LogDirFailureTest ` failures,
reproducible locally as well as on the build:
```
testIOExceptionDuringLogRoll(String).quorum=kraft
viktorsomogyi commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1425600506
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +198,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils
soarez commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1425505344
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +198,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils.pollUn
viktorsomogyi commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1853976752
@rondagostino would you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
viktorsomogyi commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1425393002
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils
soarez commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1424698314
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils.pollUn
soarez commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1424296842
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils.pollUn
viktorsomogyi commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1424228084
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils
viktorsomogyi commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1424228084
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils
viktorsomogyi commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1424228084
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
TestUtils
soarez commented on PR #14977:
URL: https://github.com/apache/kafka/pull/14977#issuecomment-1847778976
@viktorsomogyi: Thanks for starting this! Right, we'll need #14881, #14902,
#14954 and [KAFKA-15893](https://issues.apache.org/jira/browse/KAFKA-15893) to
run this.
I'm going to be
22 matches
Mail list logo
