ijuma commented on PR #14384:
URL: https://github.com/apache/kafka/pull/14384#issuecomment-1758021595
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
msn-tldr commented on PR #14384:
URL: https://github.com/apache/kafka/pull/14384#issuecomment-1757962406
@ijuma this is merged in 3.6 now, so should be available in 3.6.1.
https://github.com/apache/kafka/pull/14522
--
This is an automated message from the Apache Git Service.
To respond
wcarlson5 merged PR #14522:
URL: https://github.com/apache/kafka/pull/14522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
msn-tldr commented on PR #14522:
URL: https://github.com/apache/kafka/pull/14522#issuecomment-1757644848
CI failed with unrelated flaky tests, see below. JDK17 had a 100% green run.
JDK11 -
https://ge.apache.org/s/q2va7lqt4kk3g/tests/overview?outcome=FLAKY,FAILED
JDK20 -
https://ge.ap
msn-tldr opened a new pull request, #14522:
URL: https://github.com/apache/kafka/pull/14522
…14384)
This PR backports https://github.com/apache/kafka/pull/14384
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit
ijuma commented on PR #14384:
URL: https://github.com/apache/kafka/pull/14384#issuecomment-1749230972
Would it make sense to backport this to 3.6 as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
msn-tldr commented on PR #14384:
URL: https://github.com/apache/kafka/pull/14384#issuecomment-1749004750
@wcarlson5 thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wcarlson5 merged PR #14384:
URL: https://github.com/apache/kafka/pull/14384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
msn-tldr commented on PR #14384:
URL: https://github.com/apache/kafka/pull/14384#issuecomment-1748637611
Looking through CI failures -
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14384/8/pipeline/10/
For JDK 11 - The 2 flaky runs, and are unr
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1346188807
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3146,6 +3149,97 @@ public void testInvalidTxnStateIsAnAbortableError()
th
wcarlson5 commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1346128343
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java:
##
@@ -94,9 +100,42 @@ public ProducerBatch(TopicPartition tp,
MemoryRecords
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1345789833
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java:
##
@@ -94,9 +100,45 @@ public ProducerBatch(TopicPartition tp,
MemoryRecordsB
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1345592537
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -156,6 +157,8 @@ public class SenderTest {
private SenderMetricsRegist
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1345590803
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java:
##
@@ -94,9 +100,40 @@ public ProducerBatch(TopicPartition tp,
MemoryRecordsB
kirktrue commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1344502781
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java:
##
@@ -94,9 +100,45 @@ public ProducerBatch(TopicPartition tp,
MemoryRecordsB
wcarlson5 commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1344314253
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java:
##
@@ -94,9 +100,45 @@ public ProducerBatch(TopicPartition tp,
MemoryRecords
msn-tldr commented on PR #14384:
URL: https://github.com/apache/kafka/pull/14384#issuecomment-1743383185
@kirktrue
> @jsancio - can you weigh in about changes to org.apache.kafka.common
needing a KIP?
I have removed the changes to public classes, so this shouldn't require a
KIP,
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1340370371
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -156,6 +157,8 @@ public class SenderTest {
private SenderMetricsRegist
18 matches
Mail list logo
