Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-12 Thread via GitHub
yashmayya merged PR #14518: URL: https://github.com/apache/kafka/pull/14518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-12 Thread via GitHub
yashmayya commented on PR #14518: URL: https://github.com/apache/kafka/pull/14518#issuecomment-1759205904 Test failures are unrelated, merging to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-11 Thread via GitHub
yashmayya commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1356053586 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-11 Thread via GitHub
C0urante commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1355538647 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
yashmayya commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1354103192 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
kpatelatwork commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1353833312 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software F

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
yashmayya commented on PR #14518: URL: https://github.com/apache/kafka/pull/14518#issuecomment-1755155655 @C0urante would you be able to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
yashmayya opened a new pull request, #14518: URL: https://github.com/apache/kafka/pull/14518 - https://issues.apache.org/jira/browse/KAFKA-15570 - Currently, the [MemoryConfigBackingStore](https://github.com/apache/kafka/blob/6e164bb9ace3ea7a1a9542904d1a01c9fd3a1b48/connect/runtime/src/ma