Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2024-01-24 Thread via GitHub
github-actions[bot] commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1909287506 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-26 Thread via GitHub
drawxy commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1780481601 > > > I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-25 Thread via GitHub
hudeqi commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1778612496 > > I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-25 Thread via GitHub
drawxy commented on code in PR #14553: URL: https://github.com/apache/kafka/pull/14553#discussion_r1371202846 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1156,6 +1156,9 @@ class LogManager(logDirs: Seq[File], // we will add metrics back after sourceLog

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-25 Thread via GitHub
drawxy commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1778571795 > I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-24 Thread via GitHub
drawxy closed pull request #14553: KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log URL: https://github.com/apache/kafka/pull/14553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-24 Thread via GitHub
drawxy commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1778559531 > I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-24 Thread via GitHub
hudeqi commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1778486603 I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-24 Thread via GitHub
hudeqi commented on code in PR #14553: URL: https://github.com/apache/kafka/pull/14553#discussion_r1371126756 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1156,6 +1156,9 @@ class LogManager(logDirs: Seq[File], // we will add metrics back after sourceLog

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-24 Thread via GitHub
hudeqi commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1777085932 > Kindly ping @hudeqi Thanks for your ping, @drawxy I will review this PR in next two days. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-24 Thread via GitHub
drawxy commented on PR #14553: URL: https://github.com/apache/kafka/pull/14553#issuecomment-1777068865 Kindly ping @hudeqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log [kafka]

2023-10-16 Thread via GitHub
drawxy opened a new pull request, #14553: URL: https://github.com/apache/kafka/pull/14553 Recently, I encountered a issue that there was always 1 partition having only 1 ISR (no produce traffic on this topic). The bug is related to altering log dir. When replacing current log with future