dajac merged PR #14589:
URL: https://github.com/apache/kafka/pull/14589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1376679603
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1500,6 +1502,8 @@ class KafkaApis(val requestChannel: RequestChannel,
new OffsetFetchResponseData.Off
dajac commented on PR #14589:
URL: https://github.com/apache/kafka/pull/14589#issuecomment-1783398978
@dongnuo123 One of the build is still red. You may have to merge trunk to
get the latest changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dongnuo123 commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1373846331
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4385,15 +4451,39 @@ class KafkaApisTest {
.setGroupId("group-3")
.setErrorCode
dongnuo123 commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1373847099
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4385,15 +4451,39 @@ class KafkaApisTest {
.setGroupId("group-3")
.setErrorCode
dongnuo123 commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1373846331
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4385,15 +4451,39 @@ class KafkaApisTest {
.setGroupId("group-3")
.setErrorCode
dajac commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1373349480
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4385,15 +4451,39 @@ class KafkaApisTest {
.setGroupId("group-3")
.setErrorCode(Erro
dongnuo123 commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1372463509
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -268,7 +269,9 @@ public
CompletableFuture consumerGroupHea
dajac commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1371818152
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -310,16 +313,22 @@ public CompletableFuture joinGroup(
