dajac merged PR #14656:
URL: https://github.com/apache/kafka/pull/14656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399570354
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399533922
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -146,37 +145,33 @@ class HeartbeatRequestTest(cluster: ClusterInstance)
extends GroupCoordinat
dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399513481
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -146,37 +145,33 @@ class HeartbeatRequestTest(cluster: ClusterInstance)
extends GroupCoordinat
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399513759
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -146,37 +145,33 @@ class HeartbeatRequestTest(cluster: ClusterInstance)
extends GroupCoor
dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399513128
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399512038
##
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##
@@ -267,56 +267,106 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstance)
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399505215
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -146,37 +145,33 @@ class HeartbeatRequestTest(cluster: ClusterInstance)
extends GroupCoor
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399503522
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -146,37 +145,33 @@ class HeartbeatRequestTest(cluster: ClusterInstance)
extends GroupCoor
dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399501464
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -146,37 +145,33 @@ class HeartbeatRequestTest(cluster: ClusterInstance)
extends GroupCoordinat
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399461488
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -0,0 +1,204 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1398980007
##
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##
@@ -492,4 +569,4 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstance) {
dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1395906098
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -0,0 +1,145 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1394662269
##
core/src/test/scala/unit/kafka/server/LeaveGroupRequestTest.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1374903378
##
core/src/test/scala/unit/kafka/server/LeaveGroupRequestTest.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1374900874
##
core/src/test/scala/unit/kafka/server/LeaveGroupRequestTest.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dongnuo123 opened a new pull request, #14656:
URL: https://github.com/apache/kafka/pull/14656
This pr is based on https://github.com/apache/kafka/pull/14589,
Adding integration tests for Heartbeat API and GroupLeave API.
### JIRA
https://issues.apache.org/jira/browse/KAFKA-15705
17 matches
Mail list logo