Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-17 Thread via GitHub
mumrah commented on PR #14719: URL: https://github.com/apache/kafka/pull/14719#issuecomment-1816420476 @mimaison yup, I closed it just now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-17 Thread via GitHub
mimaison commented on PR #14719: URL: https://github.com/apache/kafka/pull/14719#issuecomment-1816083065 Can we now close https://issues.apache.org/jira/browse/KAFKA-15799? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-16 Thread via GitHub
cmccabe merged PR #14719: URL: https://github.com/apache/kafka/pull/14719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-16 Thread via GitHub
cmccabe commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1396148312 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -567,7 +567,6 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfig,

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
mumrah commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394884307 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -567,7 +567,6 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfig,

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
mumrah commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1395024903 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -55,6 +56,64 @@ trait ZkFinalizedFeatureCache { def getFeatureOption: Option[Features] }

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
mumrah commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394886188 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -376,6 +436,24 @@ class ZkMetadataCache( // This method returns the deleted TopicPartitions

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
mumrah commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394884307 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -567,7 +567,6 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfig,

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
cmccabe commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394832061 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -376,6 +436,24 @@ class ZkMetadataCache( // This method returns the deleted TopicPartitions

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
cmccabe commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394828896 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -376,6 +436,24 @@ class ZkMetadataCache( // This method returns the deleted TopicPartitions

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
cmccabe commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394827643 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -55,6 +56,64 @@ trait ZkFinalizedFeatureCache { def getFeatureOption: Option[Features] }

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
cmccabe commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394820962 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -55,6 +56,64 @@ trait ZkFinalizedFeatureCache { def getFeatureOption: Option[Features] }

Re: [PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-15 Thread via GitHub
cmccabe commented on code in PR #14719: URL: https://github.com/apache/kafka/pull/14719#discussion_r1394818560 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -567,7 +567,6 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaConfig,

[PR] KAFKA-15799 Handle full metadata updates on ZK brokers [kafka]

2023-11-08 Thread via GitHub
mumrah opened a new pull request, #14719: URL: https://github.com/apache/kafka/pull/14719 TODO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-