mimaison commented on PR #14759:
URL: https://github.com/apache/kafka/pull/14759#issuecomment-1816625357
Is the work complete? If so can we close
[KAFKA-15802](https://issues.apache.org/jira/browse/KAFKA-15802)?
--
This is an automated message from the Apache Git Service.
To respond to th
satishd merged PR #14759:
URL: https://github.com/apache/kafka/pull/14759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #14759:
URL: https://github.com/apache/kafka/pull/14759#issuecomment-1813729407
There are a few unrelated test failures, merging it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jeqo commented on PR #14759:
URL: https://github.com/apache/kafka/pull/14759#issuecomment-1810780948
cc @satishd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
jeqo opened a new pull request, #14759:
URL: https://github.com/apache/kafka/pull/14759
Cherrypick from https://github.com/apache/kafka/pull/14727 into trunk
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage
satishd merged PR #14727:
URL: https://github.com/apache/kafka/pull/14727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on PR #14727:
URL: https://github.com/apache/kafka/pull/14727#issuecomment-1810604177
There are a few unrelated test failures, merging the changes to trunk and
3.6 branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
satishd commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392586437
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
private static final L
jeqo commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392302131
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -988,6 +998,10 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, ExecutionE
jeqo commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392253771
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
private static final Logg
kamalcph commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392241202
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1652,22 +1679,23 @@ public void
testDeleteLogSegmentDueToRetentionSizeBreach(int segmentCount
kamalcph commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392226674
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1652,22 +1679,23 @@ public void
testDeleteLogSegmentDueToRetentionSizeBreach(int segmentCount
satishd commented on PR #14727:
URL: https://github.com/apache/kafka/pull/14727#issuecomment-1809750341
@jeqo Please maintain the commit history if possible as it helps in
reviewing the updated commits in the PR. It is fine if you need to rebase and
merge the commits for valid reasons.
-
satishd commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392178184
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
private static final L
jeqo commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392139277
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
private static final Logg
satishd commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1392031838
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
private static final L
jeqo commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1391798949
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -988,30 +997,33 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, ExecutionE
jeqo commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1391797997
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable {
private static final Logg
divijvaidya commented on code in PR #14727:
URL: https://github.com/apache/kafka/pull/14727#discussion_r1391297279
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -988,30 +997,33 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, Execut
jeqo commented on PR #14727:
URL: https://github.com/apache/kafka/pull/14727#issuecomment-1808280889
@divijvaidya good catch!
Although, in the case of delete there's no exception as deleting a segment
that is not present on remote does not throw an exception as it's idempotent.
Regardle
jeqo opened a new pull request, #14727:
URL: https://github.com/apache/kafka/pull/14727
See commits for more details
[[KAFKA-15802](https://issues.apache.org/jira/browse/KAFKA-15802)]
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementatio
21 matches
Mail list logo
