Re: [PR] KAFKA-15803: Update leader epoch in commitAsync and committed [kafka]

2023-11-24 Thread via GitHub
lucasbru merged PR #14817: URL: https://github.com/apache/kafka/pull/14817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15803: Update leader epoch in commitAsync and committed [kafka]

2023-11-24 Thread via GitHub
lucasbru commented on PR #14817: URL: https://github.com/apache/kafka/pull/14817#issuecomment-1825403240 Test failures unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15803: Update leader epoch in commitAsync and committed [kafka]

2023-11-23 Thread via GitHub
lucasbru commented on code in PR #14817: URL: https://github.com/apache/kafka/pull/14817#discussion_r140866 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -204,6 +206,24 @@ public void testCommitted() { }

Re: [PR] KAFKA-15803: Update leader epoch in commitAsync and committed [kafka]

2023-11-23 Thread via GitHub
cadonna commented on code in PR #14817: URL: https://github.com/apache/kafka/pull/14817#discussion_r1403241148 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -204,6 +206,24 @@ public void testCommitted() { }

[PR] KAFKA-15803: Update leader epoch in commitAsync and committed [kafka]

2023-11-22 Thread via GitHub
lucasbru opened a new pull request, #14817: URL: https://github.com/apache/kafka/pull/14817 To align the new consumer completely with the legacy consumer, we need to update the latest seen leader epoch in the metadata both when we commit offsets with a leader epoch using