cadonna merged PR #14859:
URL: https://github.com/apache/kafka/pull/14859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on code in PR #14859:
URL: https://github.com/apache/kafka/pull/14859#discussion_r1412110677
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -663,6 +662,10 @@ public Map
committed(final Set
AndrewJSchofield commented on code in PR #14859:
URL: https://github.com/apache/kafka/pull/14859#discussion_r1411266359
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -653,7 +652,7 @@ public Map
committed(final Set();
+
kirktrue commented on code in PR #14859:
URL: https://github.com/apache/kafka/pull/14859#discussion_r1411224159
##
checkstyle/suppressions.xml:
##
@@ -48,7 +48,7 @@
Review Comment:
Thank you for this clean up!
##
AndrewJSchofield commented on PR #14859:
URL: https://github.com/apache/kafka/pull/14859#issuecomment-1831950136
https://issues.apache.org/jira/browse/KAFKA-15932 opened for flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AndrewJSchofield closed pull request #14859: KAFKA-15842: Correct handling of
KafkaConsumer.committed for new consumer
URL: https://github.com/apache/kafka/pull/14859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
AndrewJSchofield commented on PR #14859:
URL: https://github.com/apache/kafka/pull/14859#issuecomment-1831514140
Closing and reopening PR to retry failed build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AndrewJSchofield opened a new pull request, #14859:
URL: https://github.com/apache/kafka/pull/14859
This PR fixes some details of the interface to KafkaConsumer.committed which
were different between the existing consumer and the new consumer.
Adds a unit test that validates the
