apoorvmittal10 commented on PR #16506:
URL: https://github.com/apache/kafka/pull/16506#issuecomment-2221126033
Thanks for the PR @OmniaGM, I do see `GroupCoordinatorConfig` also follows
new way for configs 👍
--
This is an automated message from the Apache Git Service.
To respond to the m
chia7712 merged PR #16506:
URL: https://github.com/apache/kafka/pull/16506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
OmniaGM commented on PR #16506:
URL: https://github.com/apache/kafka/pull/16506#issuecomment-2220229776
> lgtm. I was wondering how the refactoring that @OmniaGM is doing for
config would affect the work we are doing on KIP-932.
@AndrewJSchofield I believe it shouldn't have significan
chia7712 commented on code in PR #16506:
URL: https://github.com/apache/kafka/pull/16506#discussion_r1671289997
##
server/src/main/java/org/apache/kafka/server/config/ShareGroupConfig.java:
##
@@ -100,4 +102,124 @@ public class ShareGroupConfigs {
.define(SHARE_GROU
OmniaGM commented on PR #16506:
URL: https://github.com/apache/kafka/pull/16506#issuecomment-2217711694
> @OmniaGM as the summary of [#16458
(comment)](https://github.com/apache/kafka/pull/16458#issuecomment-220683),
if the `ShareGroupConfig` is not dynamic we can introduce local attrib
chia7712 commented on PR #16506:
URL: https://github.com/apache/kafka/pull/16506#issuecomment-2208796052
@OmniaGM as the summary of
https://github.com/apache/kafka/pull/16458#issuecomment-220683, if the
`ShareGroupConfig` is not dynamic we can introduce local attributes and
validate al
