Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-23 Thread via GitHub
dajac merged PR #14800: URL: https://github.com/apache/kafka/pull/14800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-22 Thread via GitHub
dongnuo123 commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1402122588 ## core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-22 Thread via GitHub
dajac commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1401815563 ## clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java: ## @@ -37,6 +37,12 @@ public JoinGroupResponse(JoinGroupResponseData data, short versio

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-21 Thread via GitHub
dajac commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1400988059 ## core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala: ## @@ -0,0 +1,402 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-21 Thread via GitHub
dongnuo123 commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1400986806 ## core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-21 Thread via GitHub
dajac commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1400987513 ## core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala: ## @@ -0,0 +1,402 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-21 Thread via GitHub
dongnuo123 commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1400981634 ## core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-21 Thread via GitHub
dongnuo123 commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1400981634 ## core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-21 Thread via GitHub
dongnuo123 commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1400973546 ## core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala: ## @@ -0,0 +1,402 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-21 Thread via GitHub
dajac commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1400798929 ## core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-19 Thread via GitHub
dongnuo123 commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1398581376 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1616,6 +1616,7 @@ public CoordinatorResult genericGroupJoin(

[PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-19 Thread via GitHub
dongnuo123 opened a new pull request, #14800: URL: https://github.com/apache/kafka/pull/14800 This pr is based on https://github.com/apache/kafka/pull/14656, Adding integration tests for JoinGroup API and SyncGroup API. ### JIRA https://issues.apache.org/jira/browse/KAFKA-15856