Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
lucasbru merged PR #14831: URL: https://github.com/apache/kafka/pull/14831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
lucasbru commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1832440394 There is already a ticket for this. [KAFKA-15900](https://issues.apache.org/jira/browse/KAFKA-15900) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831690844 Yeah, the test was flaky before in PR builds but not on trunk [1]. Could you at least create a ticket for it? [1]

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
lucasbru commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831472098 The test is failing in legacy consumer code, and this PR did not touch legacy consumer code. The test failure may be related to the CTR refactoring, but not to this particular

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831442687 I am asking because I see the follwing log: ``` [2023-11-23 16:29:05,394] ERROR Asynchronous auto-commit of offsets failed: Commit cannot be completed since the group has already

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831439167 @lucasbru Is the following test failure related: ``` org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest.testOutdatedCoordinatorAssignment() ``` -- This

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-27 Thread via GitHub
lucasbru commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1827514236 @philipnee could you please take a look before @cadonna reviews this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-23 Thread via GitHub
lucasbru opened a new pull request, #14831: URL: https://github.com/apache/kafka/pull/14831 There is no callback associated with autocommit, so I do not think we need this event. This closes KAFKA-15865. ### Committer Checklist (excluded from commit message) - [ ] Verify design