Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on PR #15312: URL: https://github.com/apache/kafka/pull/15312#issuecomment-2021512097 @kirktrue, I will -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-03-26 Thread via GitHub
jeffkbkim commented on code in PR #15312: URL: https://github.com/apache/kafka/pull/15312#discussion_r1539875541 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -87,8 +92,8 @@ public void run() { try {

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-02-27 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15312: URL: https://github.com/apache/kafka/pull/15312#discussion_r1504404988 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -87,8 +92,8 @@ public void run() { try {

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-02-21 Thread via GitHub
jeffkbkim commented on code in PR #15312: URL: https://github.com/apache/kafka/pull/15312#discussion_r1498498011 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -87,8 +92,8 @@ public void run() { try {

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-02-04 Thread via GitHub
Phuc-Hong-Tran commented on PR #15312: URL: https://github.com/apache/kafka/pull/15312#issuecomment-1925989408 @philipnee, PTAL. Thanks in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-02-03 Thread via GitHub
Phuc-Hong-Tran closed pull request #15312: KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? URL: https://github.com/apache/kafka/pull/15312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-02-03 Thread via GitHub
Phuc-Hong-Tran opened a new pull request, #15312: URL: https://github.com/apache/kafka/pull/15312 Changes: 1. Added backgroundEventHandler to ConsumerNetworkThread to handle unexpected exception. ### Committer Checklist (excluded from commit message) - [ ] Verify design