junrao commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1413208491
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,10 +45,6 @@ public short oldestAllowedVersion() {
@Overrid
apoorvmittal10 commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1413198971
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,10 +45,6 @@ public short oldestAllowedVersion() {
apoorvmittal10 commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1413198971
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,10 +45,6 @@ public short oldestAllowedVersion() {
cmccabe merged PR #14860:
URL: https://github.com/apache/kafka/pull/14860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on PR #14860:
URL: https://github.com/apache/kafka/pull/14860#issuecomment-1834306862
> Can we also fix the builder version handling here?
> With this fixed, LGTM
Good catch. The best way to fix this would be to add "ignorable" to the JSON
definition, so that it w
cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409942673
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -386,4 +418,21 @@ public void testOffsetCommitValueVersion(MetadataVersion
cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409942437
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -329,19 +336,44 @@ public void
testIsDelegationTokenSupported(MetadataVer
cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409941745
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -207,6 +213,22 @@ public enum MetadataVersion {
*/
public static fi
cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409941250
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -42,13 +42,13 @@
"about": "The epoch of the partition leader." },
{ "name": "Part
cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409938934
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -2191,7 +2191,7 @@ class PartitionTest extends AbstractPartitionTest {
val partition = new Par
cmccabe commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409900140
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -59,10 +59,14 @@ object StorageTool extends Logging {
case "format" =>
val directories =
cmccabe commented on PR #14860:
URL: https://github.com/apache/kafka/pull/14860#issuecomment-1832698639
> Left a few comments, nothing major directly on the changes.
>
> I do have a high-level thought to put out there. This currently prevents
the storage tool from formatting with a no
soarez commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409826262
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -207,6 +213,22 @@ public enum MetadataVersion {
*/
public static fin
rondagostino commented on code in PR #14860:
URL: https://github.com/apache/kafka/pull/14860#discussion_r1409696104
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -59,10 +59,14 @@ object StorageTool extends Logging {
case "format" =>
val director
cmccabe opened a new pull request, #14860:
URL: https://github.com/apache/kafka/pull/14860
Assign MetadataVersion.IBP_3_7_IV2 to JBOD.
Move KIP-966 support to MetadataVersion.IBP_3_7_IV3.
Create MetadataVersion.LATEST_PRODUCTION as the latest metadata version that
can be used w
15 matches
Mail list logo
