dajac merged PR #14945:
URL: https://github.com/apache/kafka/pull/14945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1849500329
I checked all the failed tests and none of them are related to this PR.
Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jonchiu commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1847788894
Looking at the build details, it appears the tests passed. It's hung up on
processing test results.
--
This is an automated message from the Apache Git Service.
To respond to the messag
AndrewJSchofield closed pull request #14945: KAFKA-15978: Update member
information on HB response
URL: https://github.com/apache/kafka/pull/14945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1846120099
Closing and re-opening PR to rebuild.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lianetm commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1845898212
LGTM as it is now. The fixes coming up after will also ensure it's properly
handled when the member fails, so @cadonna I think it's OK to get this one
as-is and then I'll follow-up with
AndrewJSchofield commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1845354304
> I have one comment that was not addressed:
https://github.com/apache/kafka/pull/14945/files#r1417891269. If we accept this
temporary solution, don't we think that we should at
cadonna commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1845147862
Ah, ok @AndrewJSchofield could you reply to @dajac , please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dajac commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1845144439
I have one comment that was not addressed:
https://github.com/apache/kafka/pull/14945/files#r1417891269. If we accept this
temporary solution, don't we think that we should at minimum call
AndrewJSchofield commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1843752569
Investigating failure of new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lianetm commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417895767
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return autoCo
lianetm commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417895767
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return autoCo
lianetm commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417892970
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return autoCo
dajac commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417891269
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return autoComm
dajac commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417699258
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return autoComm
AndrewJSchofield opened a new pull request, #14945:
URL: https://github.com/apache/kafka/pull/14945
In the new consumer, the commit request manager and the membership manager
are separate components. The commit request manager is initialised with group
information that it uses to construct
16 matches
Mail list logo
