philipnee commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1651126643
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -1161,8 +1155,9 @@ public void
philipnee commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1651126643
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -1161,8 +1155,9 @@ public void
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1649439786
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -747,7 +741,7 @@ public void
brenden20 commented on PR #16312:
URL: https://github.com/apache/kafka/pull/16312#issuecomment-2183474544
Thank you for the feedback @lianetm, I just made all the suggested
improvements!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
brenden20 commented on PR #16312:
URL: https://github.com/apache/kafka/pull/16312#issuecomment-2177253091
@lianetm thank you for the feedback! I have implemented all suggestions, it
is looking really good now I think!
--
This is an automated message from the Apache Git Service.
To
brenden20 commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645190334
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -366,12 +384,12 @@ public void
lianetm commented on PR #16312:
URL: https://github.com/apache/kafka/pull/16312#issuecomment-2176982668
Hey @brenden20, thanks for the changes! Took a first pass, left a few
comments. I see some other calls around tests blocked on commits that seem
confusing but I expect they may all align
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645055613
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -2457,10 +2538,7 @@ private CompletableFuture
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645039449
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -141,23 +136,41 @@ private MembershipManagerImpl
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645037904
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -81,53 +82,47 @@
import static
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645002348
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -696,21 +721,23 @@ public void
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645001767
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -660,19 +688,16 @@ public void
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1644996524
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -386,15 +404,16 @@ public void
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1644942652
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -366,12 +384,12 @@ public void
lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1644919762
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -220,6 +233,7 @@ public void
brenden20 commented on PR #16312:
URL: https://github.com/apache/kafka/pull/16312#issuecomment-2163965706
> Hey @brenden20 , assuming it's something we cannot avoid in this case, you
can suppress it with @SuppressWarnings("ClassDataAbstractionCoupling") (it's
done in other places too)
lianetm commented on PR #16312:
URL: https://github.com/apache/kafka/pull/16312#issuecomment-2163964029
Hey @brenden20 , assuming it's something we cannot avoid in this case, you
can suppress it with @SuppressWarnings("ClassDataAbstractionCoupling") (it's
done in other places too)
--
brenden20 commented on PR #16312:
URL: https://github.com/apache/kafka/pull/16312#issuecomment-2163905913
@philipnee @lianetm @kirktrue I am getting a checkstyle failure, I have one
too many class data abstractions, I am unsure on where I can fix this. Any
ideas?
--
This is an automated
brenden20 opened a new pull request, #16312:
URL: https://github.com/apache/kafka/pull/16312
I completely migrated MembershipManagerImplTest away from
ConsumerTestBuilder and removed all spy objects. All tests passing, none were
removed.
--
This is an automated message from the Apache
19 matches
Mail list logo
