cadonna merged PR #15177:
URL: https://github.com/apache/kafka/pull/15177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna opened a new pull request, #15177:
URL: https://github.com/apache/kafka/pull/15177
Kafka Streams checkpoints the wrong offset when a task is closed during
restoration. If under exactly-once processing guarantees a
TaskCorruptedException happens, the affected task is closed dirty, it
cadonna merged PR #15044:
URL: https://github.com/apache/kafka/pull/15044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1432717987
##
checkstyle/suppressions.xml:
##
@@ -230,7 +230,7 @@
+
files="(RecordCollectorTest|StreamsPartitionAssignorTest|StreamThreadTest|StreamTas
lucasbru commented on PR #15044:
URL: https://github.com/apache/kafka/pull/15044#issuecomment-1864411254
LGTM, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1432581521
##
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -1006,12 +1177,40 @@ private List> readResult(final
String topic,
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1432578710
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -1313,7 +1313,6 @@ private static List>
readRecords(final String
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1431243577
##
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -789,6 +806,158 @@ public void
shouldWriteLatestOffsetsToCheckpointOnShutd
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1431241782
##
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -789,6 +806,158 @@ public void
shouldWriteLatestOffsetsToCheckpointOnShutd
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1431220982
##
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -789,6 +806,158 @@ public void
shouldWriteLatestOffsetsToCheckpointOnShutd
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1431219204
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##
@@ -377,6 +377,11 @@ public void closeDirty() {
streamsP
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1431214126
##
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -789,6 +806,158 @@ public void
shouldWriteLatestOffsetsToCheckpointOnShutd
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1431211947
##
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -789,6 +806,158 @@ public void
shouldWriteLatestOffsetsToCheckpointOnShutd
lucasbru commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1431209859
##
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -789,6 +806,158 @@ public void
shouldWriteLatestOffsetsToCheckpointOnShut
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1430656965
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##
@@ -377,6 +377,11 @@ public void closeDirty() {
streamsP
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1430656569
##
checkstyle/import-control.xml:
##
@@ -408,6 +408,7 @@
+
Review Comment:
I needed to add this to enable
https://github.com/
cadonna commented on code in PR #15044:
URL: https://github.com/apache/kafka/pull/15044#discussion_r1430656200
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##
@@ -1228,6 +1290,7 @@ public void
shouldNotThrowStreamsExceptionOnSu
cadonna opened a new pull request, #15044:
URL: https://github.com/apache/kafka/pull/15044
Kafka Streams checkpoints the wrong offset when a task is closed during
restoration. If under exactly-once processing guarantees a
TaskCorruptedException happens, the affected task is closed dirty, it
18 matches
Mail list logo
