Re: [PR] KAFKA-16046: fix stream-stream-join store types [kafka]

2023-12-23 Thread via GitHub
mjsax commented on code in PR #15061: URL: https://github.com/apache/kafka/pull/15061#discussion_r1435548304 ## streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java: ## @@ -44,15 +45,18 @@ public class DslWindowParams { *

Re: [PR] KAFKA-16046: fix stream-stream-join store types [kafka]

2023-12-23 Thread via GitHub
mjsax commented on code in PR #15061: URL: https://github.com/apache/kafka/pull/15061#discussion_r1435548304 ## streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java: ## @@ -44,15 +45,18 @@ public class DslWindowParams { *

Re: [PR] KAFKA-16046: fix stream-stream-join store types [kafka]

2023-12-22 Thread via GitHub
lucasbru merged PR #15061: URL: https://github.com/apache/kafka/pull/15061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16046: fix stream-stream-join store types [kafka]

2023-12-22 Thread via GitHub
lucasbru commented on PR #15061: URL: https://github.com/apache/kafka/pull/15061#issuecomment-1867744948 Cause of OOM on trunk identified, so merging this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16046: fix stream-stream-join store types [kafka]

2023-12-22 Thread via GitHub
lucasbru commented on PR #15061: URL: https://github.com/apache/kafka/pull/15061#issuecomment-1867506949 Restarting the CI since we had OOM before - however, OOM affects trunk so if we don't see anything in the next run, I think we should merge this. -- This is an automated message from