Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-29 Thread via GitHub
ijuma commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1872030491 Sounds good, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-29 Thread via GitHub
showuon commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871990196 > It's usually more robust to automatically handle clean-up during tearDown by instrumenting the create method so that it keeps track of all creations. Thanks for the comment @ijuma

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
ijuma commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871302733 It's usually more robust to automatically handle clean-up during tearDown by instrumenting the create method so that it keeps track of all creations. -- This is an automated message from

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871285636 backported to 3.6 and 3.7 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
divijvaidya merged PR #15084: URL: https://github.com/apache/kafka/pull/15084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871281383 There are other test failures but `ControllerAPIsTest` is successful. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15084/1/testReport/kafka.server/ControllerApisT