cadonna merged PR #15455:
URL: https://github.com/apache/kafka/pull/15455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kirktrue commented on PR #15455:
URL: https://github.com/apache/kafka/pull/15455#issuecomment-1982356780
@cadonna—failing tests seem unrelated. Is this OK to merge? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1513515432
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -29,10 +30,19 @@ public abstract class CommitEvent extends
Complet
cadonna commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1512371153
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -29,10 +30,19 @@ public abstract class CommitEvent extends
Completa
kirktrue commented on PR #15455:
URL: https://github.com/apache/kafka/pull/15455#issuecomment-1977608445
@cadonna—please let me know if there are any outstanding concerns on the
overall approach or any details in this PR. Thanks!
--
This is an automated message from the Apache Git Service
kirktrue commented on PR #15455:
URL: https://github.com/apache/kafka/pull/15455#issuecomment-1977607424
@AndrewJSchofield—please provide clarification on your comments 🙏 Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511898298
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -177,7 +177,7 @@ private void process(final FetchComm
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511896707
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -29,8 +30,8 @@ public abstract class CommitEvent extends
Completab
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511880187
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -199,7 +205,8 @@ public void testResetPositionsProcessFailur
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511879304
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -170,7 +173,8 @@ public void testSyncCommitEvent() {
@T
cadonna commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511735767
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -177,7 +177,7 @@ private void process(final FetchCommi
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511613214
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -937,13 +938,14 @@ public Map
committed(final Set committedOffsets
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511610634
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -177,7 +177,7 @@ private void process(final FetchComm
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511608584
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -153,15 +154,17 @@ public void testMetadataUpdateEvent() {
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1511608177
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -29,8 +30,8 @@ public abstract class CommitEvent extends
Completab
cadonna commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1510930206
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -177,7 +177,7 @@ private void process(final FetchCommi
AndrewJSchofield commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1510342872
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -153,15 +154,17 @@ public void testMetadataUpdateEve
kirktrue commented on PR #15455:
URL: https://github.com/apache/kafka/pull/15455#issuecomment-1974030036
@cadonna—can you review this PR as part of the larger timeout handling
refactoring? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
kirktrue opened a new pull request, #15455:
URL: https://github.com/apache/kafka/pull/15455
This is part of the larger task of enforcing the timeouts for application
events, per KAFKA-15974.
This takes a first step by adding a `Timer` to all of the
`CompletableApplicationEvent` subcl
19 matches
Mail list logo
