Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-06-03 Thread via GitHub
gharris1727 commented on PR #15165: URL: https://github.com/apache/kafka/pull/15165#issuecomment-2146082430 Test failures appear unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-06-03 Thread via GitHub
kamalcph commented on PR #15165: URL: https://github.com/apache/kafka/pull/15165#issuecomment-2145809561 @gharris1727 @showuon Can we merge this patch? We may have to update the commit title. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-30 Thread via GitHub
kamalcph commented on code in PR #15165: URL: https://github.com/apache/kafka/pull/15165#discussion_r1620748127 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -254,6 +259,61 @@ public void testCanProcessRecord() throws

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-30 Thread via GitHub
kamalcph commented on PR #15165: URL: https://github.com/apache/kafka/pull/15165#issuecomment-2139233455 Reviewing the patch, I'll provide my comments by today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-29 Thread via GitHub
AnatolyPopov commented on code in PR #15165: URL: https://github.com/apache/kafka/pull/15165#discussion_r1619366626 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -254,6 +259,61 @@ public void testCanProcessRecord() thro

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-29 Thread via GitHub
gharris1727 commented on code in PR #15165: URL: https://github.com/apache/kafka/pull/15165#discussion_r1619287340 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -254,6 +259,61 @@ public void testCanProcessRecord() throw

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-29 Thread via GitHub
AnatolyPopov commented on PR #15165: URL: https://github.com/apache/kafka/pull/15165#issuecomment-2137680984 @showuon sorry for the delay, I've got the corona last week and still sick. But anyways tried to address the comments, please have a look! -- This is an automated message from the

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-29 Thread via GitHub
showuon commented on PR #15165: URL: https://github.com/apache/kafka/pull/15165#issuecomment-2136958616 @AnatolyPopov , any update for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-23 Thread via GitHub
AnatolyPopov commented on PR #15165: URL: https://github.com/apache/kafka/pull/15165#issuecomment-2127525649 Thanks @gharris1727 and @showuon for the comments. I'll focus on this starting from tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-23 Thread via GitHub
showuon commented on code in PR #15165: URL: https://github.com/apache/kafka/pull/15165#discussion_r1611532703 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -241,16 +258,25 @@ public void testCanProcessRecord() throws

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-16 Thread via GitHub
gharris1727 commented on code in PR #15165: URL: https://github.com/apache/kafka/pull/15165#discussion_r1603758912 ## clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java: ## @@ -248,7 +248,10 @@ public synchronized ConsumerRecords poll(final Duration timeo