gharris1727 commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2146082430
Test failures appear unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
kamalcph commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2145809561
@gharris1727 @showuon
Can we merge this patch? We may have to update the commit title.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
kamalcph commented on code in PR #15165:
URL: https://github.com/apache/kafka/pull/15165#discussion_r1620748127
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -254,6 +259,61 @@ public void testCanProcessRecord() throws
kamalcph commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2139233455
Reviewing the patch, I'll provide my comments by today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
AnatolyPopov commented on code in PR #15165:
URL: https://github.com/apache/kafka/pull/15165#discussion_r1619366626
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -254,6 +259,61 @@ public void testCanProcessRecord() thro
gharris1727 commented on code in PR #15165:
URL: https://github.com/apache/kafka/pull/15165#discussion_r1619287340
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -254,6 +259,61 @@ public void testCanProcessRecord() throw
AnatolyPopov commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2137680984
@showuon sorry for the delay, I've got the corona last week and still sick.
But anyways tried to address the comments, please have a look!
--
This is an automated message from the
showuon commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2136958616
@AnatolyPopov , any update for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AnatolyPopov commented on PR #15165:
URL: https://github.com/apache/kafka/pull/15165#issuecomment-2127525649
Thanks @gharris1727 and @showuon for the comments. I'll focus on this
starting from tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message
showuon commented on code in PR #15165:
URL: https://github.com/apache/kafka/pull/15165#discussion_r1611532703
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -241,16 +258,25 @@ public void testCanProcessRecord() throws
gharris1727 commented on code in PR #15165:
URL: https://github.com/apache/kafka/pull/15165#discussion_r1603758912
##
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java:
##
@@ -248,7 +248,10 @@ public synchronized ConsumerRecords poll(final
Duration timeo
11 matches
Mail list logo