showuon merged PR #15235:
URL: https://github.com/apache/kafka/pull/15235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15235:
URL: https://github.com/apache/kafka/pull/15235#issuecomment-1905168949
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon commented on code in PR #15235:
URL: https://github.com/apache/kafka/pull/15235#discussion_r1461360949
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -101,6 +101,10 @@ protected LeaderState(
* @return the remainingMs before the checkQuorumTimer
jsancio commented on code in PR #15235:
URL: https://github.com/apache/kafka/pull/15235#discussion_r1459322086
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -101,6 +101,10 @@ protected LeaderState(
* @return the remainingMs before the checkQuorumTimer
mimaison commented on PR #15235:
URL: https://github.com/apache/kafka/pull/15235#issuecomment-1900657870
Yes, this issue was introduced in
https://github.com/apache/kafka/commit/37416e1aebae33d01d5059ba906ec8e0e1107284
--
This is an automated message from the Apache Git Service.
To respon
stanislavkozlovski commented on PR #15235:
URL: https://github.com/apache/kafka/pull/15235#issuecomment-1900646211
I guess this is a regression from
https://issues.apache.org/jira/browse/KAFKA-15489 ?
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on PR #15235:
URL: https://github.com/apache/kafka/pull/15235#issuecomment-1899645426
@mimaison , please help review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon commented on code in PR #15235:
URL: https://github.com/apache/kafka/pull/15235#discussion_r1458256739
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -101,6 +101,10 @@ protected LeaderState(
* @return the remainingMs before the checkQuorumTimer
showuon opened a new pull request, #15235:
URL: https://github.com/apache/kafka/pull/15235
When there's only 1 voter, there will be no fetch request from other voters.
In this case, we should still not expire the checkQuorum timer because there's
just 1 voter.
### Committer Checklist
