dajac merged PR #15446:
URL: https://github.com/apache/kafka/pull/15446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
jeffkbkim commented on PR #15446:
URL: https://github.com/apache/kafka/pull/15446#issuecomment-2030301885
Fixed. Other test failures are unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on PR #15446:
URL: https://github.com/apache/kafka/pull/15446#issuecomment-2022239076
@jeffkbkim There are failed tests that look related. Could you check them
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jeffkbkim commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1539809862
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1920,6 +1921,49 @@ public void onLoaded() {
});
dajac commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1539240498
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1920,6 +1921,49 @@ public void onLoaded() {
});
}
jeffkbkim commented on PR #15446:
URL: https://github.com/apache/kafka/pull/15446#issuecomment-2018694290
thanks @dajac. I have addressed your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dajac commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1515878176
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -9607,6 +9609,104 @@ public void
testOnConsumerGroupStateTrans
dajac commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1515870996
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,63 @@ public void onLoaded() {
});
}
jeffkbkim commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1509457561
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,63 @@ public void onLoaded() {
});
jeffkbkim commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1509452557
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,63 @@ public void onLoaded() {
});
dajac commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1508764392
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,63 @@ public void onLoaded() {
});
}
jeffkbkim commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1507948503
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,64 @@ public void onLoaded() {
});
jeffkbkim opened a new pull request, #15446:
URL: https://github.com/apache/kafka/pull/15446
In the new coordinator, we have lingering timers (heartbeats/revocation
timeouts/join groups/sync groups). For classic groups, we also have awaiting
join/sync futures that are never completed. This
13 matches
Mail list logo
