Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-13 Thread via GitHub
mimaison commented on PR #15293: URL: https://github.com/apache/kafka/pull/15293#issuecomment-1941526722 Can we close https://issues.apache.org/jira/browse/KAFKA-16180 now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-02 Thread via GitHub
cmccabe merged PR #15293: URL: https://github.com/apache/kafka/pull/15293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1475200369 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1475198190 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1475196894 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
mumrah commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1474508267 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1474870992 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1474870992 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
mumrah commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1473671017 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-01-31 Thread via GitHub
mumrah commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1473671017 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String,