dajac commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1920964896
@nizhikov FYI - I merged this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac merged PR #15253:
URL: https://github.com/apache/kafka/pull/15253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1473247269
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandler.java:
##
@@ -158,36 +295,71 @@ public ApiResult handleResponse(
AndrewJSchofield commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1473234152
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandler.java:
##
@@ -158,36 +295,71 @@ public ApiResult
dajac commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1919372877
Thanks @cadonna! I have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cadonna commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1472830748
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandler.java:
##
@@ -89,18 +97,42 @@ public AdminApiLookupStrategy
dajac commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1916713439
Hey @mimaison! As you have done some work in this area, I wonder if you
would be interested by reviewing this PR. It would help us with the KIP-848
effort. We need this as soon as possible
dajac commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1471105525
##
clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupDescription.java:
##
@@ -36,6 +37,7 @@ public class ConsumerGroupDescription {
private final
dajac commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1471064233
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -240,10 +240,11 @@ private CompletableFuture maybeAutoCommit(final
dajac commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1915007420
Thanks for letting me know, @nizhikov. I can definitely adapt my PR when
https://github.com/apache/kafka/pull/15256 gets merged. However, I cannot wait
too long because this PR is needed
nizhikov commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1914941776
Hello @dajac
Right now I have #15256 which moves `DescribeConsumerGroupTest` and
`ConsumerGroupCommandTest` to tools module.
You are modifying those tests in PR.
My PR is
dajac commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1912511055
cc @nizhikov @jolshan FYI - I have a few minor changes related to the
consumer group command here. As saw that you’re working on migrating it to Java.
--
This is an automated message
dajac commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1465170111
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandler.java:
##
@@ -89,18 +96,42 @@ public AdminApiLookupStrategy
dajac opened a new pull request, #15253:
URL: https://github.com/apache/kafka/pull/15253
WIP - Needs https://github.com/apache/kafka/pull/15205 and
https://github.com/apache/kafka/pull/15211.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
14 matches
Mail list logo
