Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru merged PR #15401: URL: https://github.com/apache/kafka/pull/15401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1526229909 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -116,14 +116,14 @@ public class HeartbeatRequestManager imp

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1526193892 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -116,14 +116,14 @@ public class HeartbeatRequestManager implem

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1526177488 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1526107034 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -116,14 +116,14 @@ public class HeartbeatRequestManager implem

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1526096328 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1526079968 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1526035266 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1525955340 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1525952640 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1525935835 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1525926407 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -428,9 +429,28 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1509566835 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -524,10 +524,10 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1509566281 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -545,6 +545,15 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1507409271 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -524,10 +524,10 @@ public void testHeartbeatState() {

Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

lucasbru commented on code in PR #15401: URL: https://github.com/apache/kafka/pull/15401#discussion_r1507409979 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -545,6 +545,15 @@ public ConsumerGroupHeartbeatRequestData bu

[PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

phong260702 opened a new pull request, #15401: URL: https://github.com/apache/kafka/pull/15401 When the consumer rejoins, heartbeat request builder make sure that all fields are sent in the heartbeat request. ### Committer Checklist (excluded from commit message) - [ ] Verify desig