Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-02-12 Thread via GitHub
OmniaGM commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1938859808 > The issues started for 3.7 on the same day so it is one of the 3 commits backported feb 2

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-02-09 Thread via GitHub
jolshan commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1936789321 The issues started for 3.7 on the same day so it is one of the 3 commits backported feb 2

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-02-09 Thread via GitHub
jolshan commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1936787524 Hey folks. We've seen a large increase in LogDirFailureTest after this PR. Can we take a look and see if something here caused it? gradle enterprise:

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-02-02 Thread via GitHub
cmccabe merged PR #15262: URL: https://github.com/apache/kafka/pull/15262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-31 Thread via GitHub
gaurav-narula commented on code in PR #15262: URL: https://github.com/apache/kafka/pull/15262#discussion_r1473210077 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig, // retrieve the UUID here

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-31 Thread via GitHub
cmccabe commented on code in PR #15262: URL: https://github.com/apache/kafka/pull/15262#discussion_r1473174695 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig, // retrieve the UUID here because

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-31 Thread via GitHub
cmccabe commented on code in PR #15262: URL: https://github.com/apache/kafka/pull/15262#discussion_r1473174695 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig, // retrieve the UUID here because

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-29 Thread via GitHub
OmniaGM commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1914824513 Tests Compilation is failing with ``` [2024-01-26T16:18:05.648Z] > Task :core:compileTestScala [2024-01-26T16:18:05.648Z] [Error]

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-26 Thread via GitHub
gaurav-narula commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1912105919 @showuon added a test with commit https://github.com/apache/kafka/pull/15262/commits/d0858deb5500ebdec071bc06ca6f98726ae6f602. Please take a look -- This is an automated message

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-26 Thread via GitHub
gaurav-narula commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1911962461 > I think the impact of this bug is that if there are more than 1 log dirs in ZK broker, and when the 1st of them is failed, we will shutdown the broker unexpectedly. But if

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-25 Thread via GitHub
gaurav-narula commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1910271761 CC: @cmccabe @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific