ijuma commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488353336
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerSta
jolshan commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488290251
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerS
ijuma commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488125293
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerSta
ijuma commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488125293
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerSta
jolshan merged PR #15324:
URL: https://github.com/apache/kafka/pull/15324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jeqo commented on PR #15324:
URL: https://github.com/apache/kafka/pull/15324#issuecomment-1936481385
@jolshan thanks for catching this! adding it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jolshan commented on PR #15324:
URL: https://github.com/apache/kafka/pull/15324#issuecomment-1936317088
Hey there @jeqo looks like check style failed. Do you mind adding the apache
header to your new benchmark?
```/home/jenkins/workspace/Kafka_kafka-pr_PR-15324/jmh-benchmarks/src/mai
jeqo commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1483676179
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java:
##
@@ -0,0 +1,82 @@
+package org.apache.kafka.jmh.storage;
+
+import org.apach
jolshan commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1483652492
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java:
##
@@ -0,0 +1,82 @@
+package org.apache.kafka.jmh.storage;
+
+import org.ap
jolshan commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1483650845
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java:
##
@@ -0,0 +1,82 @@
+package org.apache.kafka.jmh.storage;
+
+import org.ap
jolshan commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1483649564
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerS
jeqo commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1482430278
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerStat
jolshan commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1482140038
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerS
jolshan commented on PR #15324:
URL: https://github.com/apache/kafka/pull/15324#issuecomment-1932990160
Also @jeqo -- just curious which java version were you running?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jeqo commented on PR #15324:
URL: https://github.com/apache/kafka/pull/15324#issuecomment-1932429115
@jolshan sure! I just added it 👍🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
jolshan commented on PR #15324:
URL: https://github.com/apache/kafka/pull/15324#issuecomment-1930479050
Hey @jeqo thanks for taking a look and improving this area!
Can we add the benchmarks from the ticket to the PR description?
--
This is an automated message from the Apache Git Se
jeqo opened a new pull request, #15324:
URL: https://github.com/apache/kafka/pull/15324
[[KAFKA-16229](https://issues.apache.org/jira/browse/KAFKA-16229)]
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
17 matches
Mail list logo