[PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-28 Thread via GitHub
lucasbru opened a new pull request, #15440: URL: https://github.com/apache/kafka/pull/15440 The internal SubscriptionState object keeps track of whether the assignment is user-assigned, or auto-assigned. If there are no assigned partitions, the assignment resets to NONE. If you call Subscri

Re: [PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-28 Thread via GitHub
lucasbru commented on PR #15440: URL: https://github.com/apache/kafka/pull/15440#issuecomment-1969266254 @AndrewJSchofield could you have a look, since you created the ticket? I wasn't quite sure in which sequence of events to observed the problem. The unit test emulates clearing the assign

Re: [PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-29 Thread via GitHub
cadonna commented on PR #15440: URL: https://github.com/apache/kafka/pull/15440#issuecomment-1970897046 @lucasbru Unit tests are failing in `MembershipManagerImplTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-29 Thread via GitHub
cadonna commented on code in PR #15440: URL: https://github.com/apache/kafka/pull/15440#discussion_r1507610459 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -764,6 +766,44 @@ public void testLeaveGroupWhenMemberOwnsAss

Re: [PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-29 Thread via GitHub
lucasbru commented on code in PR #15440: URL: https://github.com/apache/kafka/pull/15440#discussion_r1507649418 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -764,6 +766,44 @@ public void testLeaveGroupWhenMemberOwnsAs

Re: [PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-29 Thread via GitHub
lucasbru commented on code in PR #15440: URL: https://github.com/apache/kafka/pull/15440#discussion_r1507649930 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -764,6 +766,44 @@ public void testLeaveGroupWhenMemberOwnsAs

Re: [PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-03-01 Thread via GitHub
lucasbru merged PR #15440: URL: https://github.com/apache/kafka/pull/15440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache