Re: [PR] KAFKA-16286; Notify listener of latest leader and epoch [kafka]

2024-02-23 Thread via GitHub
jsancio merged PR #15397: URL: https://github.com/apache/kafka/pull/15397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16286; Notify listener of latest leader and epoch [kafka]

2024-02-21 Thread via GitHub
jsancio commented on PR #15397: URL: https://github.com/apache/kafka/pull/15397#issuecomment-1957122692 All of the `raft:test` tests passed. There seem to be some unrelated failures. Running the tests again. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-16286; Notify listener of latest leader and epoch [kafka]

2024-02-20 Thread via GitHub
jsancio commented on PR #15397: URL: https://github.com/apache/kafka/pull/15397#issuecomment-1955046620 > Is there any chance we could fire leader change more than once on a transition? (I guess this might be allowable behavior?) Thanks. I updated the KRaft tests to check that there n

Re: [PR] KAFKA-16286; Notify listener of latest leader and epoch [kafka]

2024-02-20 Thread via GitHub
jsancio commented on code in PR #15397: URL: https://github.com/apache/kafka/pull/15397#discussion_r1496389863 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -2958,6 +2958,59 @@ public void testHandleCommitCallbackFiresInCandidateState() throws Exce

[PR] KAFKA-16286; Notify listener of latest leader and epoch [kafka]

2024-02-20 Thread via GitHub
jsancio opened a new pull request, #15397: URL: https://github.com/apache/kafka/pull/15397 KRaft was only notifying listeners of the latest leader and epoch when the replica transition to a new state. This can result in the listener never getting notified if the registration happened after