Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

chia7712 merged PR #15655: URL: https://github.com/apache/kafka/pull/15655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

gaurav-narula commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1552109605 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1528,4 +1530,29 @@ public void testHandshakeUnwrapContinuesUnwrapping

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

chia7712 commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1552096474 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1528,4 +1530,29 @@ public void testHandshakeUnwrapContinuesUnwrappingOnNee

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

OmniaGM commented on PR #15655: URL: https://github.com/apache/kafka/pull/15655#issuecomment-2037372617 Nice catch @gaurav-narula! the fix seems straightforward! LGTM assuming the pipeline will pass -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

gaurav-narula commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1551794309 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1528,4 +1530,30 @@ public void testHandshakeUnwrapContinuesUnwrapping

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

OmniaGM commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1551791995 ## clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java: ## @@ -204,7 +204,9 @@ public void close() throws IOException { } catch (S

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

OmniaGM commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1551791995 ## clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java: ## @@ -204,7 +204,9 @@ public void close() throws IOException { } catch (S

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

OmniaGM commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1551790292 ## clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java: ## @@ -1528,4 +1530,30 @@ public void testHandshakeUnwrapContinuesUnwrappingOnNeed

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

OmniaGM commented on code in PR #15655: URL: https://github.com/apache/kafka/pull/15655#discussion_r1551787559 ## clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java: ## @@ -199,6 +199,14 @@ public void close() throws IOException { } catch (IOEx

Re: [PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

gaurav-narula commented on PR #15655: URL: https://github.com/apache/kafka/pull/15655#issuecomment-2037308254 CC: @rajinisivaram @ijuma @harshach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] KAFKA-16471: invoke SSLEngine::closeInbound on SslTransportLayer close [kafka]

gaurav-narula opened a new pull request, #15655: URL: https://github.com/apache/kafka/pull/15655 Invokes `SSLEngine::closeInbound` after we flush close_notify alert to the socket. This fixes memory leak in Netty/OpenSSL based SSLEngine which only free native resources once closeInbound has