Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-08 Thread via GitHub
showuon merged PR #15817: URL: https://github.com/apache/kafka/pull/15817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-08 Thread via GitHub
showuon commented on PR #15817: URL: https://github.com/apache/kafka/pull/15817#issuecomment-2099912904 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-06 Thread via GitHub
satishd commented on PR #15817: URL: https://github.com/apache/kafka/pull/15817#issuecomment-2095255793 @abhijeetk88 for reviewing the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-04 Thread via GitHub
showuon commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1589925627 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1245,19 +1260,27 @@ public static boolean

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-03 Thread via GitHub
kamalcph commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1589055167 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-03 Thread via GitHub
showuon commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1588971961 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-03 Thread via GitHub
kamalcph commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1588785888 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-03 Thread via GitHub
kamalcph commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1588784969 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-03 Thread via GitHub
kamalcph commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1588785888 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-03 Thread via GitHub
kamalcph commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1588784969 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-03 Thread via GitHub
kamalcph commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1588781775 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-05-01 Thread via GitHub
showuon commented on code in PR #15817: URL: https://github.com/apache/kafka/pull/15817#discussion_r1587041449 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1217,26 +1217,41 @@ public String toString() { * @return true if the remote segment's

Re: [PR] KAFKA-16511: Fix the leaking tiered segments during segment deletion [kafka]

2024-04-27 Thread via GitHub
kamalcph commented on PR #15817: URL: https://github.com/apache/kafka/pull/15817#issuecomment-2081328537 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific