Re: [PR] KAFKA-16536: Use BeginQuorumEpoch as leader heartbeat [kafka]

2024-07-02 Thread via GitHub
jsancio commented on code in PR #16399: URL: https://github.com/apache/kafka/pull/16399#discussion_r1653272787 ## raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java: ## @@ -866,6 +872,27 @@ public void testGrantVote(boolean isLogUpToDate) {

Re: [PR] KAFKA-16536: Use BeginQuorumEpoch as leader heartbeat [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16399: URL: https://github.com/apache/kafka/pull/16399#discussion_r1651117067 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -628,7 +629,7 @@ void deliverResponse(int correlationId, Node source, ApiMessage

Re: [PR] KAFKA-16536: Use BeginQuorumEpoch as leader heartbeat [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16399: URL: https://github.com/apache/kafka/pull/16399#discussion_r1651079179 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2096,6 +2096,26 @@ private long maybeAppendBatches( return timeUntilDrain; } +

Re: [PR] KAFKA-16536: Use BeginQuorumEpoch as leader heartbeat [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16399: URL: https://github.com/apache/kafka/pull/16399#discussion_r1651084728 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -220,7 +234,14 @@ public Uuid localDirectoryId() { return localDirectoryId; } -