chia7712 merged PR #16355:
URL: https://github.com/apache/kafka/pull/16355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
frankvicky commented on PR #16355:
URL: https://github.com/apache/kafka/pull/16355#issuecomment-2172550434
Hi @chia7712, I have refactor the test case, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1642017586
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,29 @@ class PlaintextAdminIntegrationTest extends
frankvicky commented on PR #16355:
URL: https://github.com/apache/kafka/pull/16355#issuecomment-2171469766
Hi @chia7712, I have make a change based on your comment, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641728889
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
frankvicky commented on PR #16355:
URL: https://github.com/apache/kafka/pull/16355#issuecomment-2170997483
Hi @TaiJuWu
I have make a change about assertions, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
frankvicky commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641587447
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
frankvicky commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641587398
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
TaiJuWu commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641243077
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
TaiJuWu commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641243077
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
TaiJuWu commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641243077
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
TaiJuWu commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641231798
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
frankvicky opened a new pull request, #16355:
URL: https://github.com/apache/kafka/pull/16355
We currently do not have tests for the `includeDocumentation` query option.
If the option is set to false, `ConfigEntry[documentation]` should be null.
Otherwise, it should return the
13 matches
Mail list logo
