chia7712 commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2171118271
> If we mark core Formatter to deprecate, should It need to delete at next
Kafka version?
yep if we push the code to deprecate them in 3.9.0
--
This is an automated message from
m1a2st commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2171062358
If we mark core Formatter to deprecate, should It need to delete at next
Kafka version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
chia7712 commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2170988619
just have another idea for minimizing the changes: Maybe we don't touch the
code in the core, but we deprecate them. And then we add new message formatter
instead. For example:
1.
m1a2st commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2169144736
I think that seperate to three PRs are good, these formatter are not
dependency for each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
chia7712 commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2169105054
This PR includes many migration, and hence it gets a bit complicated. Maybe
we should separate it into different PRs. For example:
1. move `TransactionLog` to `transaction-coordina
m1a2st commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2147551725
@chia7712, Please take a look, Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2124952595
@m1a2st could you please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
m1a2st opened a new pull request, #16019:
URL: https://github.com/apache/kafka/pull/16019
These class are used by console consumer. Now I want to migrate there code
from Scala to Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o