mumrah merged PR #15918:
URL: https://github.com/apache/kafka/pull/15918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on PR #15918:
URL: https://github.com/apache/kafka/pull/15918#issuecomment-2173659574
I ran ZkMigrationIntegrationTest locally several times and didn't get any
failures. Same for ZkMigrationFailoverTest. Let's see how the next Jenkins run
goes.
--
This is an automated me
mumrah commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1642904317
##
core/src/test/scala/integration/kafka/zk/ZkMigrationFailoverTest.scala:
##
@@ -274,4 +288,135 @@ class ZkMigrationFailoverTest extends Logging {
if (zkClient !
soarez commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1642377375
##
core/src/test/scala/integration/kafka/zk/ZkMigrationFailoverTest.scala:
##
@@ -274,4 +288,135 @@ class ZkMigrationFailoverTest extends Logging {
if (zkClient !
soarez commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1642377375
##
core/src/test/scala/integration/kafka/zk/ZkMigrationFailoverTest.scala:
##
@@ -274,4 +288,135 @@ class ZkMigrationFailoverTest extends Logging {
if (zkClient !
mumrah commented on PR #15918:
URL: https://github.com/apache/kafka/pull/15918#issuecomment-2168375635
Thanks for the review @soarez! Sorry it took me so long to get back to this.
Been busy migrating clusters to KRaft :)
--
This is an automated message from the Apache Git Service.
To res
mumrah commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1640060787
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -491,6 +536,13 @@ public void run() throws Exception {
re
mumrah commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1640060787
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -491,6 +536,13 @@ public void run() throws Exception {
re
mumrah commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1640047647
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -230,16 +234,24 @@ private boolean areZkBrokersReadyForMigration() {
soarez commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1606801722
##
core/src/test/scala/integration/kafka/zk/ZkMigrationFailoverTest.scala:
##
@@ -274,4 +288,135 @@ class ZkMigrationFailoverTest extends Logging {
if (zkClient !
mumrah opened a new pull request, #15918:
URL: https://github.com/apache/kafka/pull/15918
When becoming the active KRaftMigrationDriver, there is another race
condition similar to KAFKA-16171. This time, the race is due to a stale read
from ZK. After writing to `/controller` and `/controlle
11 matches
Mail list logo
